return group members #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure AD の アプリケーションギャラリーで利用可能になるためには、少なくともGroups に対する GET でパラメータに「attributes=members」が指定されていたら、membersを付けて返す必要があると指摘されています。 本PRではひとまず、全てのリクエストに対して members を返す実装をしていますが、後に以下の対応をしようと考えています。 本PRではmembersの返し方が適切かを見て頂きたいです。 |
valerauko
reviewed
Apr 14, 2023
| def group_object_response(object) | ||
| response = find_value(object, Scimaenaga.config.group_schema.except(:members)) | ||
| members_attribute = Scimaenaga.config.group_schema[:members] | ||
| return if members_attribute.nil? |
There was a problem hiding this comment.
return response するのを忘れてました・・・。
テスト作成します。
| find_value(object, Scimaenaga.config.user_schema) | ||
| end | ||
|
|
||
| def group_object_response(object) |
There was a problem hiding this comment.
なんでこういう実装になってるのか（なんでuserみたいにfind_valueだけじゃなくmembersを手動で作ってるのか）コメント書いた方がいいと思う
| return if members_attribute.nil? | ||
|
|
||
| members_raw = find_value(object, members_attribute) | ||
| response[:members] = members_raw.map do |member| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To be available in "Application Gallery (Azure AD)", we have to support return group members.
What?
return group members