Skip to content

Mais um tratamento de index #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tivorreda64 wants to merge 1 commit into
base: minor
Choose a base branch
from
Open

Mais um tratamento de index #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion just_audio/darwin/Classes/AudioPlayer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ - (void)onComplete:(NSNotification *)notification {
_index = [_order[([_orderInv[_index] intValue] + 1) % _order.count] intValue];
[self broadcastPlaybackEvent];
_justAdvanced = YES;
} else if ([_orderInv[_index] intValue] + 1 < [_order count]) {
} else if (_index < [_orderInv count] && [_orderInv[_index] intValue] + 1 < [_order count]) {
Copy link

@talesbarreto talesbarreto Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentei mais algumas coisas pra reproduzir esse crash mas em vão...

Estou pensando aqui: se o _index for inválido, em vez de crashar vai car no else que define o estado do player como complete. Estou achando mais safe não fazer absolutamente nada quando o _index for inválido, na esperança do estado, eventualmente, ser atualizado corretamente nas próximas atualizações do AvPlayer.

[endedSource seek:kCMTimeZero];
_index = [_order[([_orderInv[_index] intValue] + 1)] intValue];
[self updateEndAction];
Expand Down