Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Add options for closecaption and cc_subtitles #94

Merged
merged 1 commit into from
Feb 2, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion layout/pages/settings/audio.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

<BaseAudioSettings id="SettingsPageContainer" class="settings-page__container">

<!-- Volume settings sub section -->

<Panel id="VolumeSubSection" class="settings-group">

<Panel class="settings-group__header">
Expand Down Expand Up @@ -120,7 +122,35 @@

</Panel>

<Panel class="settings-page__spacer" />
<!-- Closed Captions Section -->

<Panel id="AudioClosedCaptionsSubSection" class="settings-group">

<Panel class="settings-group__header">

<Label class="settings-group__title" text="#Settings_ClosedCaptions_Title" tags="audio,sound,closedcaptions" />

<TooltipPanel class="settings-group__reset" tooltip="#Settings_General_Reset">
<Button class="button" onactivate="SettingsShared.resetSettings('AudioClosedCaptionsSubSection');">
<Image class="button__icon" src="file://{images}/reset.svg" />
</Button>
</TooltipPanel>

</Panel>

<SettingsEnum text="#Settings_ClosedCaptions_Enable" convar="closecaption" hasdocspage="false">
<RadioButton group="closedcaptions" text="#Common_Off" value="0" />
<RadioButton group="closedcaptions" text="#Common_On" value="1" />
</SettingsEnum>

<SettingsEnum text="#Settings_ClosedCaptions_Subtitles" convar="cc_subtitles" hasdocspage="false">
<RadioButton group="cc_subtitles" text="#Common_Off" value="0" />
<RadioButton group="cc_subtitles" text="#Common_On" value="1" />
</SettingsEnum>

</Panel>

<!-- Audio Devices Section -->

<Panel id="AudioDevicesSubSection" class="settings-group">

Expand Down