Skip to content

Commit

Permalink
Merge pull request #359 from StoXProject/datsusc
Browse files Browse the repository at this point in the history
Added expandFilterExpressionList() in FilterLanding().
  • Loading branch information
arnejohannesholmin authored May 2, 2024
2 parents 243eadc + 091f383 commit 70895e6
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- {os: macOS-latest, r: 'release', pkgext: '.tgz'}
- {os: macOS-latest, r: '4.3', pkgext: '.tgz'}
- {os: macOS-latest, r: '4.2', pkgext: '.tgz'}
- {os: macOS-latest, r: '4.1', pkgext: '.tgz'}
# - {os: macOS-latest, r: '4.1', pkgext: '.tgz'} # Disabled due to units failure
# - {os: macOS-latest, r: '4.0', pkgext: '.tgz'} # Failing in Install system dependencies on macOS
# Disccarded due to the following missing packages on Mac for R 3.6: tinytest, Rcpp, xml2, units, stringi, data.table:
#- {os: macOS-latest, r: '3.6', pkgext: '.tgz'}
Expand Down
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: RstoxData
Version: 1.10.2-9006
Date: 2024-04-19
Version: 1.10.2-9007
Date: 2024-05-02
Title: Tools to Read and Manipulate Fisheries Data
Authors@R: c(
person(given = "Edvin",
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# RstoxData v1.10.2-9002 (2024-04-25)
* Fixed more bugs in writeLevel() and exported sanitizeExpression.

# RstoxData v1.10.2-9002 (2023-11-06)
* Added parameter format class "folderPath".
* Added branch "testing" which will deploy to the testingRepo.
Expand Down
6 changes: 5 additions & 1 deletion R/Filter.R
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,8 @@ FilterBiotic <- function(BioticData, FilterExpression = list(), FilterUpwards =
#' @export
#'
FilterAcoustic <- function(AcousticData, FilterExpression = list(), FilterUpwards = FALSE) {
# For filtering directly on the input data, we need to split the list filter expression to one level for the file and one for the table:

# For filtering directly on the input data, we need to split the list filter expression to one level for the file and one for the table:
FilterExpression <- expandFilterExpressionList(FilterExpression)

filterData(
Expand All @@ -520,6 +521,9 @@ FilterAcoustic <- function(AcousticData, FilterExpression = list(), FilterUpward
#' @export
#'
FilterLanding <- function(LandingData, FilterExpression = list(), FilterUpwards = FALSE) {
# For filtering directly on the input data, we need to split the list filter expression to one level for the file and one for the table:
FilterExpression <- expandFilterExpressionList(FilterExpression)

filterData(
LandingData,
filterExpression = FilterExpression,
Expand Down

0 comments on commit 70895e6

Please sign in to comment.