-
-
Notifications
You must be signed in to change notification settings - Fork 17
Update qodana to 2025.2 from 2025.1 #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughBumped the JetBrains Qodana JVM linter image tag in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/unit-test.yml (1)
13-14: Fork PRs caveat: added write permissions won’t apply to untrusted forks.On pull_request events from forks, GITHUB_TOKEN is read-only by default; these write scopes won’t take effect. If your intent is to publish PR comments or enhanced checks on forks, you’ll need an alternative approach (e.g., pull_request_target with strict hardening, a GitHub App, or a bot token restricted to a safe surface).
Would you like guidance on a safe pull_request_target pattern for Qodana that avoids code execution risks from forks?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/unit-test.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: rob93c
PR: Stickerifier/Stickerify#298
File: qodana.yaml:6-6
Timestamp: 2024-11-02T11:09:02.322Z
Learning: The `jetbrains/qodana-jvm:2024.2` linter has been released and is available on DockerHub as of November 2024, and can be safely used in `qodana.yaml` files.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Execute unit tests (macos-13)
- GitHub Check: Execute unit tests (windows-latest)
- GitHub Check: Execute unit tests (ubuntu-latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/unit-test.yml (1)
59-60: Dropchecks: writeunless you need the Checks UI; SARIF upload already handledGiven
post-pr-comment: false,pr-mode: false, and a separate SARIF upload step,checks: writeis likely unnecessary. Keep it only if you explicitly want Qodana to create/update a Check Run in the “Checks” tab. Otherwise, prefer least privilege.Apply this diff to remove the permission from the qodana job:
qodana: - permissions: - checks: write + # permissions: + # checks: write # Uncomment only if you rely on Qodana Check Runs outputAdditionally (outside the selected range), consider scoping permissions per job:
- tests job: permissions: contents: write (needed for Gradle dependency graph submit)
- qodana job: permissions: security-events: write (needed for SARIF upload)
This allows removing the top-level
security-events: writeand keeping each job minimal.Would you like me to propose a full workflow patch that scopes permissions per job as above?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/unit-test.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: rob93c
PR: Stickerifier/Stickerify#298
File: qodana.yaml:6-6
Timestamp: 2024-11-02T11:09:02.322Z
Learning: The `jetbrains/qodana-jvm:2024.2` linter has been released and is available on DockerHub as of November 2024, and can be safely used in `qodana.yaml` files.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build and upload Docker image
- GitHub Check: Execute unit tests (windows-latest)
- GitHub Check: Execute unit tests (macos-13)
- GitHub Check: Execute unit tests (ubuntu-latest)
Summary by CodeRabbit