Skip to content

Add repro tests for SqlServerStringTypeMapping collection type mapping #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add repro tests for SqlServerStringTypeMapping collection type mapping #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c79487
Upgrade nugets
angularsen Mar 10, 2025
fd13572
Add repro tests for SqlServerStringTypeMapping collection type mapping
angularsen Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/SimplerSoftware.EntityFrameworkCore.SqlServer.NodaTime.Tests/LocalDateQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,5 +193,29 @@ public async Task LocalDate_DateDiff_Day()

Assert.Equal(6, raceResults.Count);
}

[Fact]
public async Task LocalDate_ContainedByConstantDates()
{
var dates = new[]{ new LocalDate(2019, 1, 1), new LocalDate(2019, 2, 1) };
var raceResults = await this.Db.Race.Where(r => EF.Constant(dates).Contains(r.Date)).ToListAsync();
Assert.Equal(
condense($"{RaceSelectStatement} WHERE [r].[Date] IN ('2019-01-01', '2019-02-01')"),
condense(this.Db.Sql));

Assert.Equal(2, raceResults.Count);
}

[Fact]
public async Task LocalDate_ContainedByParameterDates()
{
var dates = new[]{ new LocalDate(2019, 1, 1), new LocalDate(2019, 2, 1) };
var raceResults = await this.Db.Race.Where(r => EF.Parameter(dates).Contains(r.Date)).ToListAsync();
Assert.Equal(
condense($"{RaceSelectStatement} WHERE -- TODO WRITE ME WHEN QUERY IS FIXED"),
condense(this.Db.Sql));

Assert.Equal(2, raceResults.Count);
}
}
}
12 changes: 6 additions & 6 deletions ...Server.NodaTime.Tests/SimplerSoftware.EntityFrameworkCore.SqlServer.NodaTime.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="NodaTime" Version="3.2.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageReference Include="NodaTime" Version="3.2.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="6.0.2">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
4 changes: 2 additions & 2 deletions ...workCore.SqlServer.NodaTime/SimplerSoftware.EntityFrameworkCore.SqlServer.NodaTime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

<ItemGroup>
<PackageReference Include="JetBrains.Annotations" Version="2024.3.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.0" />
<PackageReference Include="NodaTime" Version="3.2.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.2" />
<PackageReference Include="NodaTime" Version="3.2.1" />
</ItemGroup>

<ItemGroup>
Expand Down