Skip to content

Make module loading compatible with requirejs when used with electron. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make module loading compatible with requirejs when used with electron. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/knockout-projections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,13 +373,13 @@ See the Apache Version 2.0 License for specific language governing permissions a

// Determines which module loading scenario we're in, grabs dependencies, and attaches to KO
function prepareExports() {
if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
if (typeof define === 'function' && define.amd) {
define(['knockout'], attachToKo);
} else if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
// Node.js case - load KO synchronously
var ko = require('knockout');
attachToKo(ko);
module.exports = ko;
} else if (typeof define === 'function' && define.amd) {
define(['knockout'], attachToKo);
} else if ('ko' in global) {
// Non-module case - attach to the global instance
attachToKo(global.ko);
Expand Down
2 changes: 1 addition & 1 deletion dist/knockout-projections.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/knockout-projections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,13 +373,13 @@ See the Apache Version 2.0 License for specific language governing permissions a

// Determines which module loading scenario we're in, grabs dependencies, and attaches to KO
function prepareExports() {
if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
if (typeof define === 'function' && define.amd) {
define(['knockout'], attachToKo);
} else if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
// Node.js case - load KO synchronously
var ko = require('knockout');
attachToKo(ko);
module.exports = ko;
} else if (typeof define === 'function' && define.amd) {
define(['knockout'], attachToKo);
} else if ('ko' in global) {
// Non-module case - attach to the global instance
attachToKo(global.ko);
Expand Down