Skip to content

Conversation

@kmlzielinski
Copy link

@kmlzielinski kmlzielinski commented Feb 9, 2021

nothing happens when you call method openFit() and you don't have Google fit installed so I added callback like is in other methods

@aboveyunhai
Copy link
Collaborator

@kmlzielinski can you change to async/await syntax instead of callback. So you can simply do

 const result = await openFit();
//or 
openFit().then((msg) =>{}).

callback argument is slowly removed due to deeply nested situation and inconsistency format between code.
Extra isEnabled() can be avoided in this case.

@aboveyunhai aboveyunhai added the CODE REVIEW The PR is in review label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CODE REVIEW The PR is in review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants