Skip to content

Update/ssh UI #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update/ssh UI #51

wants to merge 3 commits into from

Conversation

stupleb
Copy link
Collaborator

@stupleb stupleb commented Jul 19, 2025

Moved things around
Added part showing how to add SSH keys via the UI and gave priority, kept guide for CLI adding, moved below
Windows/PuTTY moved down so it doesn't interrupt flow between master password and adding keys.

@stupleb stupleb requested a review from MattDHill July 19, 2025 15:59
Copy link
Member

@MattDHill MattDHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we should inlcude the start-cli portion. We don't provide start-cli instructions anywhere else. Thoughts?

@stupleb
Copy link
Collaborator Author

stupleb commented Jul 20, 2025

If someone many any of these arguments, I could be convinced...

  • There are no start-cli instructions elsewhere, so for consistency there should be none here either
  • If there were to be any start-cli instructions, or a hint to the feature existing, it would definitely be in this section
  • The guides are for the everyday user and should be simple and focus on GUI only
  • The existence of start-cli is a nice feature to show exists and should be in a guide somewhere
  • Anyone who'd use start-cli would know how to find it and use --help anyway, so doesn't need a guide

Which makes the decision maybe more one of opinion, perhaps your department. :)

@MattDHill
Copy link
Member

MattDHill commented Jul 20, 2025

Yeah, take it out. We should document start-cli itself separately in the docs, mostly by just saying it exists and very basic instructions on how to use it.

@stupleb
Copy link
Collaborator Author

stupleb commented Jul 21, 2025

Tweaked as discussed. Expanded "own SSH keys" to include the actual connection steps because I wanted to add the step about the key's passphrase (while fewer people will be using their own keys, and those who do will know what they're doing, half of users think the passphrase is their StartOS master password, so this clarification can be useful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants