Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复了web应用中收藏表情无法通过滚动条增量加载的问题 #180

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

AiNakow
Copy link
Contributor

@AiNakow AiNakow commented Feb 7, 2025

web应用中的收藏表情无法通过将滚动条拉到底来加载剩余的表情。
已在web应用和win版本的electron应用中进行了测试。

Summary by Sourcery

Bug 修復:

  • 修復網頁應用程式中,喺捲動時最愛表情符號嘅增量載入問題。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Fix incremental loading of favorite emojis in the web app when scrolling down.

Stapxs and others added 3 commits January 21, 2025 14:39
✨ 群收纳盒功能,现在你可以在群收纳盒中查看活跃的群消息了 <- Stapxs#169
✨ at 和特别关心消息现在将显示为红色文本便于查看 <- Stapxs#169
✨ 快速动画模式 💨 <- Stapxs#169
✨ 本地高级链接解析,目前只支持 electron 端
✨ 好友信息面板完善 <- Stapxs#160
🐛 修正移出群聊和撤回菜单显示判断异常 <- Stapxs#169
🐛 +1 操作未拷贝对象导致渲染移动 <- Stapxs#170
🐛 为 npx 快速启动组件限制访问路径防止非法访问 <- Stapxs#176
💩 移除英文文档和英文多语言支持
💩 调整一个判断错误导致的统计功能损坏
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AiNakow - 我已經睇咗你嘅改動 - 以下係啲意見:

整體意見

  • 加個注釋解釋使用 0.5 嘅偏移,確保日後嘅可維護性。
以下係我喺審查時睇嘅內容
  • 🟡 一般問題:發現咗1個問題
  • 🟢 安全性:一切正常
  • 🟢 測試:一切正常
  • 🟢 複雜度:一切正常
  • 🟢 文檔:一切正常

Sourcery 對開源項目係免費嘅 - 如果你鍾意我哋嘅審查,請考慮分享佢哋 ✨
幫我變得更有用!請喺每個意見度撳 👍 或 👎,我會用呢個反饋嚟改善你嘅審查。
Original comment in English

Hey @AiNakow - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Add a comment explaining the use of the 0.5 offset to ensure future maintainability.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Stapxs Stapxs changed the base branch from next to fun/202501 February 10, 2025 00:48
@Stapxs Stapxs merged commit 9010a89 into Stapxs:fun/202501 Feb 10, 2025
3 checks passed
@Stapxs Stapxs mentioned this pull request Feb 10, 2025
Stapxs added a commit that referenced this pull request Feb 10, 2025
✨ 对合并转发消息里的图片预览进行了支持 <- #173 @ishkong
✨ 对移动端 web 返回操作的优化支持 <- #159 @Stapxs
✨ 移动端增加 VConsole 便于错误调查
🐛 修正了在 Napcat 下合并转发无法查看的问题 <- #173 @ishkong
🐛 移除了非管理移出群聊的选项 <- #173 @ishkong
🐛 修正对空群名处理的异常 <- #144 @mckuhei
🐛 修正消息预显文字和图片显示异常的问题 <- #178 #179 @IamIpanda
🐛 修复了web应用中收藏表情无法通过滚动条加载下一页的问题 <- #180 @AiNakow
🐛 解决在移动端中主页面显示异常的问题
🎨 优化 logger 逻辑
🎨 优化群收纳盒的样式和逻辑
💩 优化对 capacitor 端端统计
💩 移除一个过时的彩蛋
📝 更新 copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants