Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject Bluetooth Devices as Spezi Modules #32

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 5, 2024

Inject Bluetooth Devices as Spezi Modules

♻️ Current situation & Problem

BluetoothDevices were previously inaccessible from Spezi Modules without additional infrastructure. StanfordSpezi/Spezi#105 introduced functionality to dynamically load and unload Modules from the Spezi module systems. We use that new infrastructure to make every BluetoohtDevice to be a Spezi Module.
This allows every BluetoothDevice to use the same functionality available to Spezi Modules. Further, Spezi Modules can seamlessly interact with BluetoothDevice as well.

⚙️ Release Notes

  • BluetoothDevices are now Spezi Modules.

📚 Documentation

Additional documentation section was added.

✅ Testing

Verified in Engage.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer June 5, 2024 10:23
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (4e1bdee) to head (88cdea1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   78.19%   78.11%   -0.07%     
==========================================
  Files          85       85              
  Lines        4354     4357       +3     
==========================================
- Hits         3404     3403       -1     
- Misses        950      954       +4     
Files Coverage Δ
.../Model/SemanticModel/DeviceDescriptionParser.swift 100.00% <100.00%> (ø)
...Modifier/ConnectedDevicesEnvironmentModifier.swift 100.00% <100.00%> (ø)
...ources/SpeziBluetooth/Utils/ConnectedDevices.swift 96.16% <100.00%> (-0.39%) ⬇️
Sources/SpeziBluetooth/Bluetooth.swift 87.74% <37.50%> (-2.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1bdee...88cdea1. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean approach! 🎉

Thank you @Supereg!

@Supereg Supereg merged commit efd58ff into main Jun 5, 2024
10 checks passed
@Supereg Supereg deleted the feature/device-as-modules branch June 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants