Enhancement/customize home #2
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
===========================================
+ Coverage 23.37% 42.09% +18.73%
===========================================
Files 27 21 -6
Lines 856 632 -224
===========================================
+ Hits 200 266 +66
+ Misses 656 366 -290
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Thank you for the first PR @nriedman, great to see the first code contribution!
I looked at the code and had a few feedback suggestions. Don't worry about the amount of comments, I was very detailed to ensure that you have a good learning experience and to communicate everything that I found in there. You can incorporate all of that in your next PRs and improvement for this PR and work though all of the comments step-by-step.
Let me know if you have any questions and feel free to re-request a review once you have incorporated the changes 👍
Co-authored-by: Paul Schmiedmayer <[email protected]>
…ordBDHG/ENGAGE-HF into enhancement/customize-home
Removed the following dependencies: SpeziContact SpeziScheduler SpeziMockWebService Removed filler tabs on landing page, leaving only Home.
This reverts commit e13e849.
This reverts commit db6cc26.
This reverts commit 11d0b1f.
This reverts commit dfecc84.
There was a problem hiding this comment.
Thank you for the improvement and the great work here @nriedman! Great to see that you incorporated the feedback and wonderful to see the learning curve, keep up the good work 🚀
Feel free to merge the PR once you have addressed the final comments 👍
Co-authored-by: Paul Schmiedmayer <[email protected]>
…ordBDHG/ENGAGE-HF into enhancement/customize-home
Customize Landing Page
♻️ Current situation & Problem
Currently, the app is a direct copy of the Spezi Template Application, with general views unrelated to ENGAGE-HF.
⚙️ Release Notes
📚 Documentation
The landing page now appears like this:
✅ Testing
Implemented UI tests for the Tab buttons and Static Text fields. Further testing will be implemented after authentication is integrated into the app.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: