Add support for Blood Pressure Cuff #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supereg
force-pushed
the
feature/blood-pressure-cuff
branch
from
675e185 to
7f506c8
Compare
Supereg
force-pushed
the
feature/blood-pressure-cuff
branch
from
7f506c8 to
e4b803f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 78.33% 79.54% +1.22%
==========================================
Files 29 38 +9
Lines 1144 1344 +200
==========================================
+ Hits 896 1069 +173
- Misses 248 275 +27
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
We might want to wait for StanfordSpezi/SpeziBluetooth#34 to get merged and remove the synchronizeTime method in favor of the one introduced in SpeziBluetooth. |
PSchmiedmayer
approved these changes
Jun 6, 2024
ENGAGEHF.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
ENGAGEHF/Measurement/Conversions/BloodPressureMeasurement+HKSample.swift
Outdated
Show resolved
Hide resolved
Supereg
commented
Jun 6, 2024
1 task
Supereg
added a commit
that referenced
this pull request
Jun 7, 2024
# Exclude testing code from release builds ## ♻️ Current situation & Problem In #14 we forgot to exclude some testing code from release builds resulting in a build error. This got fixed with this PR. ## ⚙️ Release Notes * Fixed release builds ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Blood Pressure Cuff
♻️ Current situation & Problem
In its current state, the application solely supports Omron Weight Scales. This PR adds basic integration with Bluetooth-enabled Blood Pressure cuffs. This required restructuring some of the models within the app. Overall the structure was slightly simplified.
Lastly, we added support for the Current Time Service for both devices, adding support for time stamp reporting within measurements.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
Additional tests were added for the new device.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: