Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of a progress Indicator for Input-Related Messages #130
Implementation of a progress Indicator for Input-Related Messages #130
Changes from all commits
bfb3664
aa4f1d9
cac4735
9535e0b
cd0086b
9e532e7
4ea9b21
23b6725
1d9870c
d45ce79
ba66177
50ae6dc
f3bc342
d3e4ebd
8e2ab27
18caaff
33abce6
69540f6
d78345a
a251efe
af5c332
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that these strings are localized. I would suggest to move this string generation in the processing state type and localize them there, we already have some similar code there.
Check failure on line 29 in ENGAGEHF/Managers/MessageManager/Message.swift
Check failure on line 29 in ENGAGEHF/Managers/MessageManager/Message.swift
Check failure on line 32 in ENGAGEHF/Managers/MessageManager/Message.swift
Check warning on line 36 in ENGAGEHF/Managers/MessageManager/Message.swift
Check warning on line 36 in ENGAGEHF/Managers/MessageManager/Message.swift
Check failure on line 36 in ENGAGEHF/Managers/MessageManager/Message.swift
Check failure on line 36 in ENGAGEHF/Managers/MessageManager/Message.swift