Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Invitation Code Setup #11

Merged
merged 2 commits into from
May 31, 2024
Merged

Improve Invitation Code Setup #11

merged 2 commits into from
May 31, 2024

Conversation

PSchmiedmayer
Copy link
Member

Improve Invitation Code Setup

⚙️ Release Notes

  • Improves the invitation code setup using auth system instead of manually passing in the user id.
  • Update dependencies

CC: @MatthewTurk247

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added bug Something isn't working enhancement New feature or request labels May 30, 2024
@PSchmiedmayer PSchmiedmayer requested a review from nriedman May 30, 2024 00:58
@PSchmiedmayer PSchmiedmayer self-assigned this May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 52.68%. Comparing base (9e3715d) to head (44910c9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   52.72%   52.68%   -0.04%     
==========================================
  Files          32       32              
  Lines        1159     1158       -1     
==========================================
- Hits          611      610       -1     
  Misses        548      548              
Files Coverage Δ
ENGAGEHF/Onboarding/InvitationCodeView.swift 79.67% <66.67%> (-0.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3715d...44910c9. Read the comment docs.

Copy link
Contributor

@nriedman nriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very reasonable to use the uid from the request instead of passing it as data.

@nriedman nriedman merged commit 8bcd7c1 into main May 31, 2024
13 of 14 checks passed
@nriedman nriedman deleted the feature/invitationCodeSetup branch May 31, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants