UI/notifications #10
UI/notifications #10
Conversation
Implemented Dashboard components, fully functioning Notifications, almost done To-do list, dummy functions for everything else. Includes stand ins for the other tabs on the home view.
|
@nriedman Feel free to tag me here and drop me a Slack message once we have incorporated the elements we discussed about in the meeting yesterday 🚀 |
|
@PSchmiedmayer I've gone ahead and incorporated the final changes we discussed. Ready for review! |
There was a problem hiding this comment.
Nice job with the PR @nriedman and great to see the next advancements for the iOS Home Screen!
I had a lot of comments across the PR. Happy to connect tomorrow to answer any questions that you might have!
In addition, we need to resolve the SwiftLint Errors and should add a small UI test that validates the Notifications or other added functionality before merging the PR.
…GAGE-HF into UI/notifications
Expandable text, bold title, tighter padding.
There was a problem hiding this comment.
Thank you for all the work in this PR @nriedman!
I fixed some very minor things in a small commit; the overall PR looks great!
It would be great if you can resolve all finished conversations and can create GitHub issues for all remaining elements that might still be open and should be addressed in future smaller or bigger PRs.
After this, feel free to merge the PR 🚀
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 79.56% 78.27% -1.29%
==========================================
Files 40 46 +6
Lines 1360 1638 +278
==========================================
+ Hits 1082 1282 +200
- Misses 278 356 +78
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Build notification system
♻️ Current situation & Problem
Currently, the home view is empty. Moving forward, the UI for the Home Screen will include notifications, most recent vitals recorded, and a button to start the biweekly survey. To begin, we implemented a notification system that pulls notifications linked to the user's document in Firebase cloud storage, then displays them at the top of the dashboard in the Home Screen.
⚙️ Release Notes
📚 Documentation
See inline documentation in NotificationManager.swift and Notification.swift.
✅ Testing
Thorough UI testing ensures that notifications are properly displayed when they are added to the user's backend Firestore, and that UI components such as the "mark complete" button and the "show more" / "show less" buttons work as intended.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: