Skip to content

Commit

Permalink
Fix Release Builds (#12)
Browse files Browse the repository at this point in the history
# Fix Release Builds

## ♻️ Current situation & Problem
- ResearchKit Info.plist formatting issues fail to upload the app to the
App Store

## ⚙️ Release Notes 
- Updates to RK 3.0.3


### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
  • Loading branch information
PSchmiedmayer authored May 31, 2024
1 parent 8bcd7c1 commit 8e57ce5
Show file tree
Hide file tree
Showing 6 changed files with 1,476 additions and 1,014 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/beta-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,5 @@ jobs:
uses: StanfordBDHG/.github/.github/workflows/firebase-deploy.yml@v2
permissions:
contents: read
with:
arguments: '--debug'
secrets:
GOOGLE_APPLICATION_CREDENTIALS_BASE64: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_BASE64 }}
4 changes: 2 additions & 2 deletions ENGAGEHF.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1258,8 +1258,8 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/StanfordSpezi/SpeziLicense";
requirement = {
branch = "dependency-list";
kind = branch;
kind = upToNextMinorVersion;
minimumVersion = 0.1.0;
};
};
97F466E62A76BBEE005DC9B4 /* XCRemoteSwiftPackageReference "SpeziOnboarding" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/StanfordBDHG/ResearchKit",
"state" : {
"revision" : "69c4977f2ecd293b4e92d11f93a818b0b6517f0c",
"version" : "3.0.2"
"revision" : "08ab0290140e5a5e0e81d46cade1f09c7282facf",
"version" : "3.0.3"
}
},
{
Expand Down Expand Up @@ -258,8 +258,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/StanfordSpezi/SpeziLicense",
"state" : {
"branch" : "dependency-list",
"revision" : "14e5581aa4dfcaeb2a3301318bc4f05bac9f182b"
"revision" : "d839e7138ca2e231f5bdd90c3e4ab06dba9bc30b",
"version" : "0.1.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion ENGAGEHF/Account/AccountSheet.swift
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ struct AccountSheet: View {
if account.signedIn && !isInSetup {
AccountOverview(isEditing: $overviewIsEditing) {
NavigationLink {
ContributionsList(projectLicense: "MIT")
ContributionsList(appName: "ENGAGE-HF", projectLicense: .mit)
} label: {
Text("LICENSE_INFO_TITLE")
}
Expand Down
4 changes: 2 additions & 2 deletions functions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ admin.initializeApp();
exports.checkInvitationCode = onCall(async (request) => {
if (!request.auth.uid) {
throw new https.HttpsError(
"unauthenticated",
"User is not properly authenticated.",
"unauthenticated",
"User is not properly authenticated.",
);
}

Expand Down
Loading

0 comments on commit 8e57ce5

Please sign in to comment.