Skip to content

Commit

Permalink
Upgrade artifact actions for archive and docker actions (#54)
Browse files Browse the repository at this point in the history
# Upgrade artifact actions for archive and docker actions

## ♻️ Current situation & Problem
We upgraded our code-coverage artifact upload and download actions to
use the new `v4` version (see #52). Our xcframework creation process and
docker container actions still use the old, slow v3 actions. This PR
upgrades them as well.


## ⚙️ Release Notes 
* Increased performance for file uploads in xcframework creation


### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
  • Loading branch information
Supereg authored Feb 24, 2024
1 parent 625d000 commit 4f79591
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/archive.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
VERSION_NUMBER=${{ inputs.version }} \
SWIFT_OBJC_INTEROP_MODE=${{ (inputs.cxxInterop && 'objcxx') || 'objc' }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.xcArchiveName }}-${{ matrix.sdk }}.xcarchive
path: ./.build/${{ inputs.xcArchiveName }}-${{ matrix.sdk }}.xcarchive
4 changes: 2 additions & 2 deletions .github/workflows/docker-build-and-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
digest="${{ steps.build.outputs.digest }}"
touch "/tmp/digests/${digest#sha256:}"
- name: Upload digest
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: digests
path: /tmp/digests/*
Expand All @@ -117,7 +117,7 @@ jobs:
- build
steps:
- name: Download digests
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: digests
path: /tmp/digests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
markdown-report-on-step-summary: true
- name: Upload ESLint report
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: eslint_report.json
path: eslint_report.json
2 changes: 1 addition & 1 deletion .github/workflows/xcframework.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
xcodebuild -version
swift --version
echo Release version: ${{ inputs.version }}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
path: ./.build
- name: Create XCFramework
Expand Down

0 comments on commit 4f79591

Please sign in to comment.