Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for bad arguments to the pack alias #175

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Add a test for bad arguments to the pack alias #175

merged 1 commit into from
Jul 16, 2019

Conversation

blag
Copy link
Contributor

@blag blag commented Jul 2, 2019

@blag blag requested review from arm4b and jinpingh July 2, 2019 01:14
arm4b
arm4b approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that

Looks good 👍

jinpingh
jinpingh approved these changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@jinpingh jinpingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blag blag merged commit 217e4ea into master Jul 16, 2019
@blag blag deleted the add-pack-alias-test branch July 16, 2019 17:03
@m4dcoder m4dcoder mentioned this pull request Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@jinpingh jinpingh jinpingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for #182/#183
3 participants
@blag @arm4b @jinpingh