Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated 'ssl on' nginx config #4917

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Apr 23, 2020

Spot during the StackStorm/community#6

Starting nginx: nginx: [warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead in /etc/nginx/conf.d/st2.conf:28

Looks like we're already using listen ssl and so ssl on; was there just for compatibility with the ancient nginx versions.

The ssl directive is deprecated in nginx 0.7.14 and is safe to remove, considering its release date in 2008.

```
Warning. Starting nginx: nginx: [warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead in /etc/nginx/conf.d/st2.conf:28
```
@arm4b arm4b added this to the 3.3.0 milestone Apr 23, 2020
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Apr 23, 2020
Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. LGTM

@arm4b arm4b marked this pull request as draft April 23, 2020 16:24
@arm4b arm4b modified the milestones: 3.3.0, 3.2.0 Apr 24, 2020
@arm4b arm4b marked this pull request as ready for review April 24, 2020 21:39
@arm4b arm4b merged commit 8313c3f into master Apr 24, 2020
@arm4b arm4b deleted the enhg/nginx-ssl-config-deprecations branch April 24, 2020 21:48
@arm4b arm4b restored the enhg/nginx-ssl-config-deprecations branch April 24, 2020 21:48
@arm4b arm4b deleted the enhg/nginx-ssl-config-deprecations branch April 24, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants