Refactor stackstorm.js a bit #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blag
force-pushed
the
refactor-stackstorm.js
branch
2 times, most recently
from
c5cc4bb to
da4dedb
Compare
blag
force-pushed
the
refactor-stackstorm.js
branch
2 times, most recently
from
7d6166f to
e192b94
Compare
blag
changed the title
arm4b
approved these changes
Jun 29, 2019
…ng consistent key ordering
blag
force-pushed
the
refactor-stackstorm.js
branch
from
a18a019 to
cddd43a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is composed of cherry-picks from #168 and a tiny bit more refactoring as well.
This PR will be considered a draft PR until StackStorm/st2chatops#124 is fixed, and will then and only then be promoted to being a full PR. I will continuously rebase this branch on top ofmasteruntil StackStorm/st2chatops#124 is fixed, so clone this branch AT YOUR OWN RISK.This PR should not change the behavior of
scripts/stackstorm.jsin any way, except for theSIGUSR2handler now emits a log message to the debug log.Tests for some environment variable settings, and for the
SIGUSR2handler are included. These tests should be orthogonal to the tests from #168 and/or #172.A note about testing: when (and ONLY when) the test assertions fail, the tests simply hang until they are interrupted with a
SIGINT(ctrl+c). Unfortunately, as far as I have learned Javascript, this is unavoidable until some of the behavioral refactoring from #168 is implemented (namely: thatst2streamis properly closed, and hubot is properly shutdown, see thefunction stopin #168 for a working example). Due to the fact fixing that requires behavioral changes inscripts/stackstorm.jsand this PR deliberately avoids changing the behavioral ofstackstorm.js(except the one place as noted above), this is considered outside the scope of this PR. When the tests are successful, the tests exit as per normal operation.