Log errors and exit on authentication issues on Hubot plugin initialization

CHANGELOG.rst

@@ -3,6 +3,8 @@ Changelog
 
 in development
 --------------
+* st2chatops now gracefully exits on authentication failures and uncaught exceptions (improvement)
+* code cleanup (improvement)
 
 0.9.3
 -----

lib/slack-messages.js

@@ -16,37 +16,6 @@
 
 var utils = require('./utils.js');
 
-// Polyfill from:
-// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign
-if (typeof Object.assign !== 'function') {
-  // Must be writable: true, enumerable: false, configurable: true
-  Object.defineProperty(Object, "assign", {
-    value: function assign(target, varArgs) { // .length of function is 2
-      if (target === null) { // TypeError if undefined or null
-        throw new TypeError('Cannot convert undefined or null to object');
-      }
-
-      var to = Object(target);
-
-      for (var index = 1; index < arguments.length; index++) {
-        var nextSource = arguments[index];
-
-        if (nextSource !== null) { // Skip over if undefined or null
-          for (var nextKey in nextSource) {
-            // Avoid bugs when hasOwnProperty is shadowed
-            if (Object.prototype.hasOwnProperty.call(nextSource, nextKey)) {
-              to[nextKey] = nextSource[nextKey];
-            }
-          }
-        }
-      }
-      return to;
-    },
-    writable: true,
-    configurable: true
-  });
-}
-
 var buildMessagesWithChunkedFieldValue = function (msg) {
   var msgs;
 

lib/slack_monkey_patch.js

@@ -24,6 +24,18 @@ function patchSendMessage(robot) {
   // formatted and parsed on the server side.
   // NOTE / TODO: We can get rid of this nasty patch once our node-slack-client and hubot-slack pull
   // requests are merged.
+  // This code was refactored in https://github.com/StackStorm/hubot-stackstorm/pull/6
+  // which was opened and merged by Kami on 2015-06-04.
+  // As of 2019-05-22, these were the PRs I could find for the node-slack-client
+  // hubot-slack repositories:
+  // * https://github.com/slackapi/node-slack-sdk/pull/42
+  //   - which was closed during a refactor and converted into an issue:
+  //     https://github.com/slackapi/node-slack-sdk/issues/138
+  // * https://github.com/slackapi/hubot-slack/pull/544
+  //   - which was opened on 2018-11-14, which seems to be too late to actually
+  //     apply to this code
+  // So...I'm not entirely sure this monkey patch is still necessary.
+  // End-to-end testing is required to figure out for sure.
   if (robot.adapter && robot.adapter.constructor && robot.adapter.constructor.name === 'SlackBot') {
     for (var channel in robot.adapter.client.channels) {
       robot.adapter.client.channels[channel].sendMessage = sendMessageRaw.bind(robot.adapter.client.channels[channel]);

package.json

@@ -37,6 +37,7 @@
   "devDependencies": {
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
+    "chai-string": "^1.5.0",
     "eslint": "^5.16.0",
     "eslint-plugin-notice": "0.7.8",
     "gulp": "^3.9.1",
@@ -48,6 +49,7 @@
     "hubot-help": "0.2.2",
     "hubot-mock-adapter": "^1.1.1",
     "log": "1.4.0",
+    "mocked-env": "^1.2.4",
     "nock": "^10.0.0",
     "nyc": "^13.0.1",
     "sinon": "^6.3.5",