Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
I haven't been able to fully dig into the changes in this PR and understand the implications, but I wanted to get a few comments and just to get a gut check. Let me know what you think @abovedave
There was a problem hiding this comment.
@abovedave Out of curiosity, why did the netlify.toml file move here?
|
|
||
| [build] | ||
| publish = "packages/stacks-docs/_site/" | ||
| command = "npm run build -w packages/stacks-docs" |
There was a problem hiding this comment.
Does this change instead need to be in the v2 branch and not in this PR which targets the main branch? Seems like it focuses on the stack-docs package, which currently is just for v2.
| # IMPORTANT!: Git LFS settings can't be changed in the .toml file. You will need to set this environment | ||
| # variable through the Netlify UI otherwise netlify won't be able to clone the repo due to all our images. | ||
| # https://docs.netlify.com/build/configure-builds/environment-variables/#netlify-configuration-variables | ||
| GIT_LFS_ENABLED = "true" # just here as a reminder No newline at end of file |
There was a problem hiding this comment.
Do we not need any of the redirects from packages/stacks-docs/netlify.toml?
|
I'm realizing now this PR probably was intended to target the |
2 participants
Reflects branch changes from #2231
See also: #2236