Skip to content

StreamGroupInfo.Lag can be null #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/StackExchange.Redis/ResultProcessor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2286,6 +2286,19 @@ internal static bool TryRead(Sequence<RawResult> pairs, in CommandBytes key, ref
}
return false;
}
internal static bool TryRead(Sequence<RawResult> pairs, in CommandBytes key, ref long? value)
{
var len = pairs.Length / 2;
for (int i = 0; i < len; i++)
{
if (pairs[i * 2].IsEqual(key) && pairs[(i * 2) + 1].TryGetInt64(out var tmp))
{
value = tmp;
return true;
}
}
return false;
}

internal static bool TryRead(Sequence<RawResult> pairs, in CommandBytes key, ref int value)
{
Expand Down Expand Up @@ -2348,7 +2361,8 @@ protected override StreamGroupInfo ParseItem(in RawResult result)
var arr = result.GetItems();
string? name = default, lastDeliveredId = default;
int consumerCount = default, pendingMessageCount = default;
long entriesRead = default, lag = default;
long entriesRead = default;
long? lag = default;

KeyValuePairParser.TryRead(arr, KeyValuePairParser.Name, ref name);
KeyValuePairParser.TryRead(arr, KeyValuePairParser.Consumers, ref consumerCount);
Expand Down
39 changes: 39 additions & 0 deletions tests/StackExchange.Redis.Tests/StreamTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2042,4 +2042,43 @@ await db.StreamAddAsync(
Assert.Equal(123, (int)obj!.id);
Assert.Equal("test", (string)obj.name);
}

[Fact]
public async Task StreamConsumerGroupInfoLagIsNull()
{
await using var conn = Create(require: RedisFeatures.v5_0_0);

var db = conn.GetDatabase();
var key = Me();
const string groupName = "test_group",
consumer = "consumer";

await db.StreamCreateConsumerGroupAsync(key, groupName);
await db.StreamReadGroupAsync(key, groupName, consumer, "0-0", 1);
await db.StreamAddAsync(key, "field1", "value1");
await db.StreamAddAsync(key, "field1", "value1");

var streamInfo = await db.StreamInfoAsync(key);
await db.StreamDeleteAsync(key, new[] { streamInfo.LastEntry.Id });

Assert.Null((await db.StreamGroupInfoAsync(key))[0].Lag);
}

[Fact]
public async Task StreamConsumerGroupInfoLagIsTwo()
{
await using var conn = Create(require: RedisFeatures.v5_0_0);

var db = conn.GetDatabase();
var key = Me();
const string groupName = "test_group",
consumer = "consumer";

await db.StreamCreateConsumerGroupAsync(key, groupName);
await db.StreamReadGroupAsync(key, groupName, consumer, "0-0", 1);
await db.StreamAddAsync(key, "field1", "value1");
await db.StreamAddAsync(key, "field1", "value1");

Assert.Equal(2, (await db.StreamGroupInfoAsync(key))[0].Lag);
}
}
Loading