YAML Loader improvements #175
Draft
+5,473
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
force-pushed
the
feature/yaml-improvements
branch
from
deb89f0 to
d311e2f
Compare
zml2008
force-pushed
the
feature/yaml-improvements
branch
from
d311e2f to
07e9753
Compare
zml2008
force-pushed
the
feature/yaml-improvements
branch
3 times, most recently
from
fc79b90 to
9d43596
Compare
zml2008
force-pushed
the
feature/yaml-improvements
branch
from
9d43596 to
1a57de0
Compare
zml2008
force-pushed
the
feature/yaml-improvements
branch
from
1a57de0 to
0ece4c2
Compare
Djaytan
added a commit
to Djaytan/mc-jobs-reborn-patch-place-break
that referenced
this pull request
Feb 12, 2023
The motivation to change the config format come from a limitation of Configurate about YAML format. It is not possible to serialize a YAML content with comments whereas this is a requirement for the project. More details can be found here about Configurate and YAML module: SpongePowered/Configurate#175
Djaytan
added a commit
to Djaytan/mc-jobs-reborn-patch-place-break
that referenced
this pull request
Feb 12, 2023
The motivation to change the config format come from a limitation of Configurate about YAML format. It is not possible to serialize a YAML content with comments whereas this is a requirement for the project. More details can be found here about Configurate and YAML module: SpongePowered/Configurate#175
This allows us to capture more information as representation hints and to precisely control the output. We can also read comments events to properly round-trip comments in configuration files
zml2008
force-pushed
the
feature/yaml-improvements
branch
from
5d2db39 to
51b134d
Compare
Closed
|
I am currently using your |
|
@zml2008 any known information about this? |
Accept some differences from the originals on our integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the YAML loader to use SnakeYaml's lower-level API
Goals are to: