Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/spikeinterface/core/sortinganalyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import spikeinterface

from spikeinterface.core import BaseRecording, BaseSorting, aggregate_channels, aggregate_units
from spikeinterface.core.waveform_tools import has_exceeding_spikes

from .recording_tools import check_probe_do_not_overlap, get_rec_attributes, do_recording_attributes_match
from .core_tools import (
Expand Down Expand Up @@ -372,6 +373,15 @@ def create(
all_probes = recording.get_probegroup().probes
check_probe_do_not_overlap(all_probes)

if has_exceeding_spikes(sorting=sorting, recording=recording):
warnings.warn(
"Your sorting has spikes with samples times greater than your recording length. These spikes have been removed."
)
# import here to avoid circular import
from spikeinterface.curation.remove_excess_spikes import RemoveExcessSpikesSorting

sorting = RemoveExcessSpikesSorting(sorting=sorting, recording=recording)

if format == "memory":
sorting_analyzer = cls.create_memory(sorting, recording, sparsity, return_in_uV, rec_attributes=None)
elif format == "binary_folder":
Expand Down
10 changes: 10 additions & 0 deletions src/spikeinterface/core/tests/test_sortinganalyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,16 @@ def test_extension():
register_result_extension(DummyAnalyzerExtension2)


def test_excess_spikes(dataset):
"""
If there are spikes that occur after the recording end time,
`create_sorting_analyzer` should cut them off and warn the user.
"""
recording, sorting = dataset
with pytest.warns(UserWarning):
create_sorting_analyzer(sorting=sorting, recording=recording.time_slice(0, 1))


def test_extensions_sorting():

# nothing happens if all parents are on the left of the children
Expand Down
Loading