Fix pysearch command validation to only allow python scripts ( #30)

[pushkar-hue]

Fixed pysearch command validation to only allow python scripts. Before it used to accept every command entered now it checks them first and guide the user to use the QuickFlow's search feature instead. This PR will close the issue #30

[SpaciousCoder78]

Thanks for the commit.

You should’ve asked to get the issue assigned to you. In general it’s a good practice to only work on the issue that’s assigned to you.

Nevertheless I will test it when I get some time but again I think you may need to make some more changes as there will be a merge conflict with another contributor’s PR from yesterday.

I will let you know about the code review later this week.

[pushkar-hue]

No worries, take your time testing it. If there’s a merge conflict or anything else that needs fixing, just ping me and I’ll handle it.

[Lonelyguy123]

I'll be doing the code review
on behalf of @SpaciousCoder78

[SpaciousCoder78]

Hello @pushkar-hue, sorry for the delay. I was a bit busy last week.

I've just tested your code and I found the following issues with it:

The code does throw an exception when something else is entered but upon testing it further, I noticed that it throws exceptions even when python or python3 is used as an argument.

Example:

QuickOverflow > search
py-search > python3 test.py
QuickOverflow Error: Only 'python' or 'python3' commands are allowed.
Use QuickOverflow’s search feature to browse directories instead.
QuickOverflow > search      
py-search > python3
QuickOverflow Error: Only 'python' or 'python3' commands are allowed.
Use QuickOverflow’s search feature to browse directories instead.

If you can fix this small bug, we can merge your PR into development branch for further testing as this is a very important feature.

[pushkar-hue]

Hey @SpaciousCoder78 , thanks for testing the PR. You are absolutely right there was an issue with
if not cmd.startswith("python") or cmd.startswith("python3"):

now fixed it, it works as intended now can you check again and let me know if there's anything else you'd like me to adjust.

[pushkar-hue]

Hello @SpaciousCoder78, after submitting the PR I realized there was an issue with how submit_error from pyoverflow3 was being used. I've added a try-except block to handle any errors and ensure it works as expected. Let me know if there's anything else you'd like me to update.

[SpaciousCoder78]

I will review your code soon.

Can you also document your changes in the code explaining what changes you made?

It makes it a lot easier to review the changes.

[pushkar-hue]

Hi @SpaciousCoder78 apologies for late reply, would you prefer me to document the changes as comments directly in the code, or in a separate file ? Happy to do whichever works best for you.

[SpaciousCoder78]

Comments in the code using # Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: NotAceNinja ***@***.***> Sent: Sunday, June 22, 2025 4:02:15 PM To: SpaciousCoder78/QuickOverflow ***@***.***> Cc: Aryan Karamtoth ***@***.***>; Mention ***@***.***> Subject: Re: [SpaciousCoder78/QuickOverflow] Fix pysearch command validation to only allow python scripts ( #30) (PR #33) [https://avatars.githubusercontent.com/u/148221995?s=20&v=4]pushkar-hue left a comment (SpaciousCoder78/QuickOverflow#33)<#33 (comment)> Hi @SpaciousCoder78<https://github.com/SpaciousCoder78> apologies for late reply, would you prefer me to document the changes as comments directly in the code, or in a separate file ? Happy to do whichever works best for you. — Reply to this email directly, view it on GitHub<#33 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVGN6UTHWET3XE7T5ZO726L3E2A27AVCNFSM6AAAAAB67UWVNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJUGEYDSOJYGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[pushkar-hue]

Added code comments to explain the changes made. Let me know if there's anything else you'd like me to do.

[SpaciousCoder78]

I've done the code review and testing and found that everything works well and perfect.

I'm merging this PR. Thank you for your contribution, I will mention you in the README