Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CONTRIBUTING.md">
<violation number="1" location="docs/CONTRIBUTING.md:199">
P2: The contributor workflow pulls from `origin` (the fork), not `upstream`. Since the fork's `dev` isn't automatically kept in sync, `git pull origin dev` may fetch stale code. Consider changing the workflow to sync from upstream, e.g.:
- Branch off dev git fetch upstream
git checkout dev && git rebase upstream/dev
git checkout -b feat/your-feature
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Collaborator
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief description of what this PR does.
Changes
Summary by cubic
Make
devthe default branch and PR target;mainis reserved for releases and hotfixes. Updated README,docs/PRD.md, anddocs/SECURITY.md, and added a fulldocs/CONTRIBUTING.mdoutlining the dev-first workflow, CI gates, environments, release/hotfix steps, and deployment triggers.upstream, fetch, and switch todev(checkout and pull latest).dev; open PRs todevonly.main; open PRs to bothmainanddev.dev → main, then syncmainback intodev.Written for commit a0415ad. Summary will update on new commits.