🌱 Don't run make targets for pr-lint on pull_request_target#232
Open
jklare wants to merge 1 commit into
Open
Conversation
jklare
force-pushed
the
jk-pr-lint-on-pull-request
branch
3 times, most recently
from
71acdbb to
417073f
Compare
* although the rule `if: github.event_name != 'pull_request_target'` makes sure to not run the pr-lint steps on pull_request_target, we should not use this event trigger, but actually use `pull_request` instead * https://docs.github.com/en/actions/reference/security/securely-using-pull_request_target Signed-off-by: Jan Klare <klare@osism.tech>
jklare
force-pushed
the
jk-pr-lint-on-pull-request
branch
from
417073f to
7f8edfe
Compare
jklare
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if: github.event_name != 'pull_request_target'makes sure to not run the pr-lint steps on pull_request_target, we should not use this event trigger, but actually usepull_requestinstead