chore: Reintroduce subdirs#270
Open
jschoone wants to merge 1 commit into
Open
Conversation
In the Container Call discussed it might be a good idea to bring the subdirs back for two main reasons: - CSO does not allow changing the Cluster Stack - We can handle breaking changes/new features in new minor versions Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
garloff
reviewed
Jul 10, 2026
garloff
left a comment
garloff
left a comment
Member
There was a problem hiding this comment.
Let's avoid too much duplication, so I suggest we
- try to only have one README (unless we expect significant divergence between them)
- clean out the references to other minor versions from the subdirectories
I'll push some changes ...
| # url: https://nbg1.your-objectstorage.com/osism/openstack-k8s-capi-images/ubuntu-2404-kube-v1.33/ubuntu-2404-kube-v1.33.12.qcow2 | ||
| # checksum: "sha256:" | ||
| # build_date: 2026-05-13 | ||
| - version: 'v1.34.0' |
Member
There was a problem hiding this comment.
Do we need the 1.34.x k8s node images in the 1-33 subdirectory?
| @@ -0,0 +1,149 @@ | |||
| # Cluster Stacks | |||
Member
There was a problem hiding this comment.
Do we expect changes significant enough between the k8s minor versions that we want to du^Wtriplicate this README file?
| - kubernetes: 1.33.11 | ||
| cinder_csi: 2.33.1 | ||
| occm: 2.33.1 | ||
| - kubernetes: 1.34.8 |
Member
There was a problem hiding this comment.
As we have a 1-33 subdirectory now, do we want to track any other k8s versions in here?
| tags: | ||
| - clusterstacks | ||
| versions: | ||
| - version: 'v1.33.4' |
Member
There was a problem hiding this comment.
Same comment as before: We don't need 1.33 in the 1-34 directory, do we?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Container Call discussed it might be a good idea to bring the subdirs back for two main reasons:
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: