DIA-6123 prevent messageUI from being created on finished()#885
Merged
andresilveirah merged 2 commits intodevelopfrom Mar 25, 2026
Merged
DIA-6123 prevent messageUI from being created on finished()#885andresilveirah merged 2 commits intodevelopfrom
finished()#885andresilveirah merged 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disposes messageUI view before setting its reference to null
Fixes a race condition causing the
onUIReadyto be called more than once while the consent ui is still being presented. More info below.onUIReady()is called (isPresenting: false → true) ✅finished(view)is called immediatelymessageUI = nullfinished()callsgetOrCreateMessageUI().isPresenting = falsegetOrCreateMessageUI()creates a NEW WebView instanceisPresenting = falseby defaultrenderNextMessageIfAny()orloadPrivacyManager()then callsgetOrCreateMessageUI().load()loaded()onUIReady()again ❌