Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add mysql support #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ezra-chu
Copy link

No description provided.

@Crim
Copy link
Collaborator

Crim commented Mar 19, 2019

Thanks for the contribution! I have the following questions/notes:

  • Do you know if it's possible to not include the MySQL client library in the POM, but instead have it available on the classpath?
    • I'm not sure if that will work, but if it does -- it may be a more sustainable path forward for supporting alternative datasources (PSQL, etc..) w/o having to package every client library w/ the release artifact.
  • Ideally some way to perform automated testing using MySQL backed data store to ensure compatibility moving forward
    • This may require CI pipeline changes? Unsure exactly the best approach here.
  • Updating/creating documentation outlining how to configure the service from the default of using it's internal H2 database to using an external MySQL instance. (How To style documentation)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants