Fix rubocop RSpec offenses

.rubocop.yml

@@ -59,3 +59,6 @@ Style/Documentation:
   Exclude:
     - 'lib/**/*'
     - 'spec/**/*'
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/**/*'

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude`
-# on 2025-10-03 05:58:19 UTC using RuboCop version 1.81.1.
+# on 2025-10-28 14:12:37 UTC using RuboCop version 1.81.6.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,109 +13,16 @@ Gemspec/DevelopmentDependencies:
   Exclude:
     - 'sorcery.gemspec'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Severity.
-Gemspec/RequireMFA:
-  Exclude:
-    - 'sorcery.gemspec'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'spec/rails_app/app/controllers/sorcery_controller.rb'
-
-# Offense count: 1
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'lib/generators/sorcery/install_generator.rb'
-
-# Offense count: 2
-# Configuration parameters: AllowedParentClasses.
-Lint/MissingSuper:
-  Exclude:
-    - 'lib/sorcery/providers/jira.rb'
-    - 'lib/sorcery/providers/xing.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, consistent
-Lint/SymbolConversion:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: Max, CountKeywordArgs, MaxOptionalParameters.
-Metrics/ParameterLists:
-  Exclude:
-    - 'lib/sorcery/test_helpers/rails/request.rb'
-
-# Offense count: 1
-# Configuration parameters: MinSize.
-Performance/CollectionLiteralInLoop:
-  Exclude:
-    - 'lib/generators/sorcery/install_generator.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: MaxKeyValuePairs.
-Performance/RedundantMerge:
-  Exclude:
-    - 'lib/sorcery/providers/line.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RegexpMatch:
-  Exclude:
-    - 'lib/sorcery/providers/github.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/StringInclude:
-  Exclude:
-    - 'lib/sorcery/providers/github.rb'
-
 # Offense count: 3
 RSpec/AnyInstance:
   Exclude:
     - 'spec/controllers/controller_oauth2_spec.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 19
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Exclude:
-    - 'spec/shared_examples/user_activity_logging_shared_examples.rb'
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-    - 'spec/shared_examples/user_remember_me_shared_examples.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEql:
-  Exclude:
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be, be_nil
-RSpec/BeNil:
-  Exclude:
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 66
 RSpec/BeforeAfterAll:
   Enabled: false
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ContextMethod:
-  Exclude:
-    - 'spec/shared_examples/user_brute_force_protection_shared_examples.rb'
-
 # Offense count: 35
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
@@ -176,14 +83,7 @@ RSpec/DescribedClass:
     - 'spec/sorcery_crypto_providers_spec.rb'
     - 'spec/sorcery_temporary_token_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterHook:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-
-# Offense count: 58
+# Offense count: 59
 # Configuration parameters: Max, CountAsOne.
 RSpec/ExampleLength:
   Exclude:
@@ -201,20 +101,6 @@ RSpec/ExampleLength:
     - 'spec/shared_examples/user_reset_password_shared_examples.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
-# DisallowedExamples: works
-RSpec/ExampleWording:
-  Exclude:
-    - 'spec/providers/vk_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExcessiveDocstringSpacing:
-  Exclude:
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
@@ -228,42 +114,6 @@ RSpec/ExpectInHook:
   Exclude:
     - 'spec/controllers/controller_spec.rb'
 
-# Offense count: 50
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
-  Exclude:
-    - 'spec/controllers/controller_activity_logging_spec.rb'
-    - 'spec/controllers/controller_http_basic_auth_spec.rb'
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/controllers/controller_oauth_spec.rb'
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-    - 'spec/controllers/controller_spec.rb'
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_activity_logging_shared_examples.rb'
-    - 'spec/shared_examples/user_brute_force_protection_shared_examples.rb'
-    - 'spec/shared_examples/user_magic_login_shared_examples.rb'
-    - 'spec/shared_examples/user_remember_me_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-    - 'spec/sorcery_crypto_providers_spec.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/HooksBeforeExamples:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: is_expected, should
-RSpec/ImplicitExpect:
-  Exclude:
-    - 'spec/controllers/controller_spec.rb'
-
 # Offense count: 72
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
@@ -275,20 +125,6 @@ RSpec/InstanceVariable:
     - 'spec/shared_examples/user_shared_examples.rb'
     - 'spec/sorcery_crypto_providers_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: it_behaves_like, it_should_behave_like
-RSpec/ItBehavesLike:
-  Exclude:
-    - 'spec/active_record/user_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/LeadingSubject:
-  Exclude:
-    - 'spec/sorcery_temporary_token_spec.rb'
-
 # Offense count: 4
 RSpec/LeakyConstantDeclaration:
   Exclude:
@@ -300,30 +136,13 @@ RSpec/MessageChain:
   Exclude:
     - 'spec/controllers/controller_oauth_spec.rb'
 
-# Offense count: 70
+# Offense count: 71
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 10
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: hash, symbol
-RSpec/MetadataStyle:
-  Exclude:
-    - 'spec/active_record/user_activation_spec.rb'
-    - 'spec/active_record/user_activity_logging_spec.rb'
-    - 'spec/active_record/user_brute_force_protection_spec.rb'
-    - 'spec/active_record/user_magic_login_spec.rb'
-    - 'spec/active_record/user_oauth_spec.rb'
-    - 'spec/active_record/user_remember_me_spec.rb'
-    - 'spec/active_record/user_reset_password_spec.rb'
-    - 'spec/active_record/user_spec.rb'
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-
-# Offense count: 103
+# Offense count: 104
 # Configuration parameters: Max.
 RSpec/MultipleExpectations:
   Exclude:
@@ -351,7 +170,7 @@ RSpec/NamedSubject:
     - 'spec/controllers/controller_session_timeout_spec.rb'
     - 'spec/controllers/controller_spec.rb'
 
-# Offense count: 9
+# Offense count: 13
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:
@@ -360,35 +179,6 @@ RSpec/NestedGroups:
     - 'spec/shared_examples/user_magic_login_shared_examples.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_remember_me_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ReceiveNever:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/controllers/controller_oauth_spec.rb'
-    - 'spec/shared_examples/user_activation_shared_examples.rb'
-    - 'spec/shared_examples/user_reset_password_shared_examples.rb'
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: and_return, block
-RSpec/ReturnFromStub:
-  Exclude:
-    - 'spec/controllers/controller_oauth2_spec.rb'
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-    - 'spec/shared_examples/user_shared_examples.rb'
-
 # Offense count: 21
 # Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata.
 RSpec/SpecFilePathFormat:
@@ -416,58 +206,9 @@ RSpec/VerifiedDoubles:
     - 'spec/controllers/controller_oauth2_spec.rb'
     - 'spec/shared_examples/user_shared_examples.rb'
 
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/Yield:
-  Exclude:
-    - 'spec/controllers/controller_brute_force_protection_spec.rb'
-    - 'spec/controllers/controller_remember_me_spec.rb'
-    - 'spec/controllers/controller_session_timeout_spec.rb'
-    - 'spec/controllers/controller_spec.rb'
-
-# Offense count: 1
-Style/DocumentDynamicEvalDefinition:
-  Exclude:
-    - 'lib/sorcery/controller/submodules/external.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/ExpandPathArguments:
-  Exclude:
-    - 'spec/rails_app/config.ru'
-
-# Offense count: 125
+# Offense count: 126
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
-
-# Offense count: 3
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: respond_to_missing?
-Style/OptionalBooleanParameter:
-  Exclude:
-    - 'lib/sorcery/controller.rb'
-    - 'lib/sorcery/controller/submodules/external.rb'
-    - 'lib/sorcery/controller/submodules/remember_me.rb'
-
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'lib/sorcery/controller/config.rb'
-    - 'lib/sorcery/controller/submodules/brute_force_protection.rb'
-    - 'lib/sorcery/controller/submodules/remember_me.rb'
-    - 'lib/sorcery/model.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowModifier.
-Style/SoleNestedConditional:
-  Exclude:
-    - 'lib/sorcery/model/submodules/brute_force_protection.rb'
-    - 'lib/sorcery/model/submodules/external.rb'
-    - 'lib/sorcery/model/submodules/user_activation.rb'

lib/generators/sorcery/install_generator.rb

@@ -4,6 +4,7 @@
 module Sorcery
   module Generators
     class InstallGenerator < Rails::Generators::Base
+      EXCLUDED_SUBMODULES = %w[http_basic_auth session_timeout core].freeze
       include Rails::Generators::Migration
       include Sorcery::Generators::Helpers
 
@@ -68,7 +69,7 @@ def copy_migration_files
         return unless submodules
 
         submodules.each do |submodule|
-          unless %w[http_basic_auth session_timeout core].include?(submodule)
+          unless EXCLUDED_SUBMODULES.include?(submodule)
             migration_template "migration/#{submodule}.rb", "db/migrate/sorcery_#{submodule}.rb", migration_class_name: migration_class_name
           end
         end
@@ -84,15 +85,16 @@ def self.next_migration_number(dirname)
         end
       end
 
-      private
-
       def self.timestamped_migrations?
         if Rails::VERSION::MAJOR >= 7
           ActiveRecord.timestamped_migrations
         else
           ActiveRecord::Base.timestamped_migrations
         end
       end
+      private_class_method :timestamped_migrations?
+
+      private
 
       def only_submodules?
         options[:migrations] || options[:only_submodules]