Set up the RuboCop environment #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop has been partially introduced so far, but I want to run it properly from now on. I installed the latest rubocop, rubocop-rspec, and rubocop-performance and wired them into CI. To keep CI behavior consistent, each gem’s version is pinned except for patch versions. All cops that currently fail are listed in .rubocop_todo.yml. I plan to work down this todo over time, but I do not intend to aggressively fix cops myself. By leaving RuboCop todos as good first issues, I want to create an entry point for new contributors. I don’t necessarily want to fix every cop in the todo. We’ll weigh the cost of following a cop’s rule against its benefit, and disable the ones where the cost outweighs the value.
In the current setup, running rake spec required RuboCop as a dependency even though I only wanted to run RSpec. I removed RuboCop from the rake task dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop has been partially introduced so far, but I want to run it properly from now on. I installed the latest rubocop, rubocop-rspec, and rubocop-performance and wired them into CI. To keep CI behavior consistent, each gem’s version is pinned except for patch versions.
All cops that currently fail are listed in .rubocop_todo.yml. I plan to work down this todo over time, but I do not intend to aggressively fix cops myself. By leaving RuboCop todos as good first issues, I want to create an entry point for new contributors.
I don’t necessarily want to fix every cop in the todo. We’ll weigh the cost of following a cop’s rule against its benefit, and disable the ones where the cost outweighs the value.