CLI-131 fix: Apply 1 SonarQube suggestion

[sonarqube-agent]

This PR includes automated code changes to address 1 SonarQube issues: MAJOR (1).

View Project in SonarCloud

---

Fixed Issues

typescript:S107 - Async function 'runFinalVerification' has too many parameters (8). Maximum allowed is 7. • MAJOR • View issue

Location: src/cli/commands/integrate/claude/index.ts:439

Why is this an issue?

Why is this an issue?

Functions with a long parameter list are difficult to use because maintainers must figure out the role of each parameter and keep track of their position.

View this code on SonarQube Cloud

The solution can be to:

• Split the function into smaller ones

View this code on SonarQube Cloud

• Find a better data structure for the parameters that group data in a way that makes sense for the specific application domain

View this code on SonarQube Cloud

This rule raises an issue when a function has more parameters than the provided threshold.

Exceptions

The rule ignores TypeScript parameter properties when counting parameters:

View this code on SonarQube Cloud

The rule also ignores Angular component constructors:

View this code on SonarQube Cloud

Resources

Documentation

• eslint - Rule max-params

What changed

Defines the FinalVerificationParams interface that groups all 8 parameters of runFinalVerification into a single object type. This provides the data structure needed to refactor the function signature from 8 individual parameters down to one, resolving the 'too many parameters' code smell.

Directly fixes the 'too many parameters' issue by replacing the 8 individual parameters of runFinalVerification with a single params: FinalVerificationParams object parameter. The parameters are then destructured inside the function body, preserving the same internal logic while reducing the parameter count from 8 to 1.

Updates the first call site of runFinalVerification to pass an object literal (opening {) instead of positional arguments, matching the new single-parameter signature that fixes the 'too many parameters' issue.

At the first call site, converts the positional argument projectInfo.root to the named property projectRoot: projectInfo.root within the object literal, since the parameter name differs from the expression being passed. This is required for the refactored function signature.

Closes the object literal at the first call site by changing ); to });, completing the conversion from positional arguments to a single object parameter.

Updates the second call site of runFinalVerification to pass an object literal (opening {) instead of positional arguments, matching the new single-parameter signature that fixes the 'too many parameters' issue.

At the second call site, converts the positional argument projectInfo.root to the named property projectRoot: projectInfo.root within the object literal, since the parameter name differs from the expression being passed. This is required for the refactored function signature.

Closes the object literal at the second call site by changing ); to });, completing the conversion from positional arguments to a single object parameter.

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -435,0 +436,11 @@ function printFinalVerificationResults(
+interface FinalVerificationParams {
+  serverURL: string;
+  token: string;
+  projectKey: string | undefined;
+  hooksRoot: string;
+  config: ConfigurationData;
+  projectRoot: string;
+  isGlobal: boolean;
+  a3sEnabled: boolean;
+}
+

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -439,10 +450,4 @@ function printFinalVerificationResults(
-async function runFinalVerification(
-  serverURL: string,
-  token: string,
-  projectKey: string | undefined,
-  hooksRoot: string,
-  config: ConfigurationData,
-  projectRoot: string,
-  isGlobal: boolean,
-  a3sEnabled: boolean,
-): Promise<void> {
+async function runFinalVerification(params: FinalVerificationParams): Promise<void> {
+  const { serverURL, token, projectKey, hooksRoot, config, projectRoot, isGlobal, a3sEnabled } =
+    params;
+

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -511,1 +516,1 @@ async function runFullSonarIntegration(
-      await runFinalVerification(
+      await runFinalVerification({

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -517,1 +522,1 @@ async function runFullSonarIntegration(
-        projectInfo.root,
+        projectRoot: projectInfo.root,

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -520,1 +525,1 @@ async function runFullSonarIntegration(
-      );
+      });

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -548,1 +553,1 @@ async function runFullSonarIntegration(
-  await runFinalVerification(
+  await runFinalVerification({

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -554,1 +559,1 @@ async function runFullSonarIntegration(
-    projectInfo.root,
+    projectRoot: projectInfo.root,

--- a/src/cli/commands/integrate/claude/index.ts
+++ b/src/cli/commands/integrate/claude/index.ts
@@ -557,1 +562,1 @@ async function runFullSonarIntegration(
-  );
+  });

---

SonarQube Remediation Agent uses AI. Check for mistakes.

DISCLAIMER: Remediation Agent will not be triggered again on this (self authored) PR

[hashicorp-vault-sonar-prod]

CLI-131