Skip to content

GHA-212 Fix CI tests for get-jira-release-notes after JET taxonomy migration#115

Open
nils-werner-sonarsource wants to merge 2 commits intomasterfrom
nw/fix-master-jet-tests
Open

GHA-212 Fix CI tests for get-jira-release-notes after JET taxonomy migration#115
nils-werner-sonarsource wants to merge 2 commits intomasterfrom
nw/fix-master-jet-tests

Conversation

@nils-werner-sonarsource
Copy link
Contributor

Summary

  • SONARPHP 3.49 issues were migrated via JET: ImprovementFeature, TaskMaintenance
  • Update integration tests to assert against current issue types in the sandbox (Feature instead of Improvement/Task)
  • Add Maintenance to the default category order in get_jira_release_notes.py (JET replacement for Task)
  • Update the unit test expected default list to include Maintenance

Test plan

  • test-get-jira-release-notes / Test Action Integration with Default Issue Categories on project with deprecated Jira taxonomy passes
  • test-get-jira-release-notes / Test Action Integration with Custom Issue Categories on project with deprecated Jira taxonomy passes
  • All other jobs in "Test All Actions" remain green

🤖 Generated with Claude Code

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix CI tests for get-jira-release-notes after JET taxonomy migration GHA-212 Fix CI tests for get-jira-release-notes after JET taxonomy migration Mar 10, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Mar 10, 2026

GHA-212

Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we're not testing backwards compatibility of the old Jira taxonomy anymore here.
If the JET migration is completed, I would suggest to completely remove one of the tests here (either IaC or PHP).
(Test name's are currently: test-custom-issue-categories-deprecated-taxonomy)
And we could think about removing backwards compatibility completely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Will clean up.

nils-werner-sonarsource and others added 2 commits March 11, 2026 08:55
SONARPHP 3.49 issues were migrated via JET: Improvement → Feature,
Task → Maintenance. Update integration tests to assert against the
current issue types in the sandbox, and add Maintenance to the default
category order in the action.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JET migration is complete, so remove the test jobs for projects using the
old taxonomy (SONARPHP) and remove backwards-compatible issue types
(New Feature, Improvement) from the default category list.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud
Copy link

SonarQube reviewer guide

Review in SonarQube

Summary: Remove deprecated Jira taxonomy support by eliminating legacy issue categories ("New Feature", "Improvement") and replacing them with modern ones ("Maintenance"), while removing associated integration tests.

Review Focus: Verify that the updated default issue category order in get_jira_release_notes.py aligns with current Jira taxonomy requirements and won't break existing integrations. Confirm the removed test cases for deprecated taxonomy are no longer needed.

Start review at: get-jira-release-notes/get_jira_release_notes.py. This file contains the core logic change that affects how release notes are categorized. The removal of backwards compatibility comments and changes to the default category ordering could impact users relying on the old taxonomy—ensure this is an intentional breaking change.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants