-
Notifications
You must be signed in to change notification settings - Fork 11
Replace pubsub+ naming #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Included JSON tutorial but left out AVRO and generic as they are essentially identical
hand crafted spelling errors Co-authored-by: Copilot <[email protected]>
…ace-dev-tutorials into jcsmp-serdes-feature
Please mark whether you used Copilot to assist coding in this PR
|
* Client-profile enabled with guaranteed messaging permissions. | ||
|
||
One simple way to get access to Solace messaging quickly is to create a messaging service in Solace PubSub+ Cloud [as outlined here](https://solace.com/products/event-broker/cloud/). You can find other ways to get access to Solace messaging below. | ||
One simple way to get access to Solace messaging quickly is to create a messaging service in Solace Solace Cloud [as outlined here](https://solace.com/products/event-broker/cloud/). You can find other ways to get access to Solace messaging below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this should be Solace Solace
...
* Using the APIs | ||
|
||
Using the Solace PubSub+ APIs to provision an endpoint can be a convenient way of getting started quickly without needing to become familiar with the management interface. This is why it is used in this tutorial. However it should be noted that the management interface provides more options to control the queue properties. So generally it becomes the preferred method over time. | ||
Using the Solace Solace Messaging APIs to provision an endpoint can be a convenient way of getting started quickly without needing to become familiar with the management interface. This is why it is used in this tutorial. However it should be noted that the management interface provides more options to control the queue properties. So generally it becomes the preferred method over time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solace Solace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you fix the files that have "Solace Solace" I don't see any other issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates product naming throughout the documentation by replacing "PubSub+" references with "Solace" in appropriate contexts. The changes standardize terminology to align with current Solace product naming conventions, improving consistency across the developer documentation.
- Replace "Solace PubSub+ API" with "Solace Messaging API"
- Update "PubSub+ Manager" to "Broker Manager"
- Change "PubSub+ Event Broker" to "Solace Event Broker"
Reviewed Changes
Copilot reviewed 59 out of 61 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/pages/tutorials/tanzu/*.md | Updated Pivotal Cloud Foundry tutorial naming from PubSub+ to Solace terminology |
src/pages/tutorials/spring/*.md | Modified Spring framework tutorial references to use Solace naming |
src/pages/tutorials/semp/*.md | Updated SEMP API tutorial documentation with current product names |
src/pages/tutorials/rest-messaging/publish-subscribe.md | Changed REST messaging tutorial to use Solace Event Broker terminology |
src/pages/tutorials/openmama/hello-world.md | Updated OpenMAMA integration tutorial naming |
src/pages/tutorials/nodejs/*.md | Modified Node.js tutorial references to current Solace naming |
src/pages/tutorials/jms/*.md | Updated JMS tutorial documentation with Broker Manager references |
src/pages/tutorials/jcsmp/*.md | Changed JCSMP tutorial naming and updated sample repository commit |
src/pages/tutorials/javascript/*.md | Modified JavaScript tutorial references to current naming |
src/pages/tutorials/java*/*.md | Updated Java-related tutorial naming conventions |
src/pages/tutorials/dotnet/*.md | Changed .NET tutorial references to Broker Manager |
src/pages/tutorials/c/*.md | Updated C API tutorial naming to Solace Event Broker |
src/pages/404.js | Updated 404 page references to Solace Event Broker |
src/components/*.js | Modified component references to use current Solace naming |
gatsby-config.js | Updated JCSMP samples repository commit reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
With the Solace Solace fixes in place can you merge @TamimiGitHub or shall I? |
I completed this change with Claude and some
sed
commands so I am moving it to a new PR so that we can do some more extensive testing on it before applying it to the public site. Claude and I did not make any changes to paths, urls, code snippets or links to code that may be broken by a change from PubSub+ convention.I clicked through every tutorial page on my local running copy and everything seems to be functioning normally. But lets not merge this change till monday at the earliest