🐛 Prevents stale cache issues in GraphQL AppDefinitionLoadingCache

SoftInstigate · Feb 6, 2025 · 089e13c · 089e13c
1 parent 2089fac
commit 089e13c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/graphql/src/main/java/org/restheart/graphql/cache/AppDefinitionLoadingCache.java b/graphql/src/main/java/org/restheart/graphql/cache/AppDefinitionLoadingCache.java
@@ -86,6 +86,11 @@ public static GraphQLApp getLoading(String appURI) throws GraphQLAppDefNotFoundE
             if (_app != null && _app.isPresent()){
                 return _app.get();
             } else {
+                // Remove key if null was cached (previous request missed it, but it may exist now)
+                if (_app != null && _app.isEmpty()) {
+                    CACHE.remove(appURI);
+                }
+
                 try {
                     _app = CACHE.getLoading(appURI);
                 } catch (Exception e) {