Skip to content

Fix for params already being a dict #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2025
Merged

Fix for params already being a dict #21

merged 3 commits into from
Feb 24, 2025

Conversation

dacoburn
Copy link
Collaborator

Public Changelog

  • Minor fix for a bug with the repos API when creating new entries. params was being treated as a class instead of a dict which could cause an error.

@dacoburn dacoburn added the product changelog Any public-facing change in the product's features label Feb 20, 2025
@dacoburn dacoburn requested a review from a team as a code owner February 20, 2025 03:50
@dacoburn dacoburn requested review from jdalton and trevnorris and removed request for a team February 20, 2025 03:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socket-sdk-python==2.0.6.dev213

Planeshifter
Planeshifter approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming params is always a dict.

@dacoburn dacoburn merged commit 4ffc7d6 into main Feb 24, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-repos-params branch February 24, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@jdalton jdalton Awaiting requested review from jdalton jdalton is a code owner automatically assigned from SocketDev/eng

@trevnorris trevnorris Awaiting requested review from trevnorris trevnorris is a code owner automatically assigned from SocketDev/eng

Assignees
No one assigned
Labels
product changelog Any public-facing change in the product's features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacoburn @Planeshifter