Added SARIF support to the CLI #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obarrera
requested review from
bcomnes and
nolanlawson
and removed request for
a team
|
❌ Version Check Failed Please increment... |
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==1.0.42.dev431Docker image: |
dacoburn
approved these changes
Jan 25, 2025
| @@ -188,6 +196,25 @@ def output_console_comments(diff_report: Diff, sbom_file_name: str = None) -> No | |||
| else: | |||
| log.info("No New Security issues detected by Socket Security") | |||
|
|
|||
| def output_console_sarif(diff_report: Diff, sbom_file_name: str = None) -> None: | |||
There was a problem hiding this comment.
@obarrera is the intention to replace printing out to the console for JSON or table format or to have it save to a file? Right now this would replace JSON/TABLE output and print out in sarig format. The other option is still do the normal output and save a file for sarif. This definitely works but I'm not sure what is better as I haven't played with sending to Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.