comparing file paths on manifest files to dedupe #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowstate
requested review from
mikolalysenko and
rchatrath7
and removed request for
a team
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==1.0.39.dev361Docker image: |
flowstate
requested review from
dacoburn
and removed request for
mikolalysenko and
rchatrath7
|
Closing since Doug's better solution is live and verified working |
dacoburn
deleted the
eric/cus-45-cli-sending-multiple-case-insensitive-copies-of-manifests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our case-insensitive file search led to us sending multiple copies of manifest files when we created a full scan. Now we are tracking seen file paths, so we only send one copy of each unique manifest