ci(release): tag after build + fix rustup toolchain setup#85
Merged
Conversation
Tag now runs after build succeeds so a failed build no longer leaves behind a dangling tag. All publish jobs depend on tag, so we never half-publish without one. Replaces dtolnay/rust-toolchain (which can't auto-detect the channel when pinned by SHA) with direct rustup invocation, matching the pattern already used in ci.yml. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Wenxin Jiang (Wenxin-Jiang)
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tagjob to run afterbuildsucceeds, so a failed build no longer leaves a dangling tag behind. All publish jobs (github-release,cargo-publish,npm-publish,pypi-publish) now depend ontag, so we never half-publish without one.dtolnay/rust-toolchainwith directrustup show+rustup target add. The dtolnay action can't auto-detect the channel when pinned by SHA (it normally parses it from the ref name like@stable), which caused the release run to fail with'toolchain' is a required input. This matches the pattern already used inci.yml.Test plan
dry-run: trueand confirm all matrix targets build successfullyv*tag is created on a dry-run🤖 Generated with Claude Code