Skip to content

Update SOCKET_CLI_COANA_LOCAL_PATH to support the Coana CLI binary #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtorp merged 1 commit into from
Nov 18, 2025
Merged

Update SOCKET_CLI_COANA_LOCAL_PATH to support the Coana CLI binary #917

mtorp merged 1 commit into from
Nov 18, 2025

Conversation

@mtorp
Copy link
Contributor

@mtorp mtorp commented Nov 18, 2025

if SOCKET_CLI_COANA_LOCAL_PATH is a binary, then run it as such instead of running it with Node.

BarrensZeppelin
BarrensZeppelin approved these changes Nov 18, 2025
View reviewed changes
Copy link

@BarrensZeppelin BarrensZeppelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mtorp mtorp merged commit 9d0164c into v1.x Nov 18, 2025
7 checks passed
@mtorp mtorp deleted the coana-binary branch November 18, 2025 11:54
jdalton added a commit that referenced this pull request Dec 9, 2025
@jdalton
fix(dlx): support Coana CLI binary execution via SOCKET_CLI_COANA_LOC…
541cd0e 
…AL_PATH

Update SOCKET_CLI_COANA_LOCAL_PATH to support the Coana CLI binary.
Check if local path is a binary (.js/.mjs extension check) and execute
directly instead of always using node.

Based on #917
Ported from v1.x commit 9d0164c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BarrensZeppelin BarrensZeppelin BarrensZeppelin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtorp @BarrensZeppelin