Small fixes

SnowletTV · Feb 14, 2025 · 23eda34 · 23eda34
1 parent 2df160c
commit 23eda34
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 23 deletions.
diff --git a/common/missions/00_indo_germanic_missions.txt b/common/missions/00_indo_germanic_missions.txt
@@ -774,9 +774,16 @@
 					}
 					set_culture = indo_germanic
 				}
-				set_primary_culture_cleanup_effect = {
-					NEW_PRIMARY_CULTURE = indo_germanic
-					MAKE_OLD_CULTURE_INTEGRATED = yes
+				if = {
+					limit = {
+						NOT = {
+							primary_culture = indo_germanic
+						}
+					}
+					set_primary_culture_cleanup_effect = {
+						NEW_PRIMARY_CULTURE = indo_germanic
+						MAKE_OLD_CULTURE_INTEGRATED = yes
+					}
 				}
 			}
 

diff --git a/common/missions/02_phoenicia_mission_01.txt b/common/missions/02_phoenicia_mission_01.txt
@@ -1928,13 +1928,19 @@
             }
             #political_influence >= 75
             OR ={
-                c:TYE = { 
-                    opinion = { 
-                        target = root 
-                        value >= 120
-                    } 
+                trigger_if = {
+                    limit = { exists = c:TYE }
+                    c:TYE = { 
+                        opinion = { 
+                            target = root 
+                            value >= 120
+                        } 
+                    }
+                    hidden:current_ruler = { is_friend = c:TYE.current_ruler } 
+                }
+                trigger_else = {
+                    always = no
                 }
-                hidden:current_ruler = { is_friend = c:TYE.current_ruler } 
             }
         }   
 

diff --git a/decisions/punt_decisions.txt b/decisions/punt_decisions.txt
@@ -3,7 +3,7 @@
 
 		potential = {
 			tag = APC
-			NOT = { has_variable = city_of_angels_taken }
+			NOT = { has_global_variable = city_of_angels_taken }
 		}
 
 		highlight = {
@@ -19,7 +19,7 @@
 		}
 
 		effect = {
-			set_variable = city_of_angels_taken
+			set_global_variable = city_of_angels_taken
 			p:8704 = {
 				add_permanent_province_modifier = {
 					name = city_of_angels_mod
@@ -40,8 +40,8 @@
 
 		potential = {
 			tag = APC
-			has_variable = city_of_angels_taken
-			NOT = { has_variable = city_of_angels_taken_2 }
+			has_global_variable = city_of_angels_taken
+			NOT = { has_global_variable = city_of_angels_taken_2 }
 		}
 
 		highlight = {
@@ -57,7 +57,7 @@
 		}
 
 		effect = {
-			set_variable = city_of_angels_taken_2
+			set_global_variable = city_of_angels_taken_2
 			p:8704 = {
 				add_permanent_province_modifier = {
 					name = city_of_angels_mod
@@ -80,10 +80,10 @@
 	city_of_angels_decision_3 = {
 
 		potential = {
-			num_of_cities >= 1
 			tag = APC
-			has_variable = city_of_angels_taken_2
-			NOT = { has_variable = city_of_angels_taken_3 }
+			num_of_cities >= 1
+			has_global_variable = city_of_angels_taken_2
+			NOT = { has_global_variable = city_of_angels_taken_3 }
 		}
 
 		highlight = {
@@ -99,7 +99,7 @@
 		}
 
 		effect = {
-			set_variable = city_of_angels_taken_3
+			set_global_variable = city_of_angels_taken_3
 			p:8704 = {
 				add_permanent_province_modifier = {
 					name = city_of_angels_mod
@@ -128,8 +128,8 @@
 		potential = {
 			num_of_cities >= 1
 			tag = APC
-			has_variable = city_of_angels_taken_2
-			NOT = { has_variable = city_of_angels_taken_4 }
+			has_global_variable = city_of_angels_taken_2
+			NOT = { has_global_variable = city_of_angels_taken_4 }
 		}
 
 		highlight = {
@@ -158,7 +158,7 @@
 		}
 
 		effect = {
-			set_variable = city_of_angels_taken_4
+			set_global_variable = city_of_angels_taken_4
 			p:8704 = {
 				add_permanent_province_modifier = {
 					name = trade_center_of_apocopa
@@ -179,7 +179,7 @@
 		potential = {
 			num_of_cities >= 1
 			tag = APC
-			NOT = { has_variable = consolidation_of_zingis_taken }
+			NOT = { has_global_variable = consolidation_of_zingis_taken }
 		}
 
 		highlight = {
@@ -199,7 +199,7 @@
 		effect = {
 			add_political_influence = -50
 			custom_tooltip = consolidation_of_zingis_tooltip
-			set_variable = consolidation_of_zingis_taken
+			set_global_variable = consolidation_of_zingis_taken
 			p:8704 = {
 				ordered_pops_in_province = {
 					limit = {