Skip to content

Escape synonym special characters on export #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape synonym special characters on export #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions ...pp/code/community/Smile/ElasticSearch/Model/Resource/CatalogSearch/Synonym/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,20 @@
*/
class Smile_ElasticSearch_Model_Resource_CatalogSearch_Synonym_Collection extends Mage_CatalogSearch_Model_Resource_Query_Collection
{

/**
* @var string[]
*/
protected $escapeMap = array(
',' => '\\,',
'\\' => '\\\\',
'=>' => '\\=>',
);

/**
* Generates the synonym list for the search engine.
*
* @return return array
* @return string[]
*/
public function exportSynonymList()
{
Expand All @@ -31,10 +41,21 @@ public function exportSynonymList()
$adapter = $this->getConnection();
$data = $adapter->fetchAll($this->getSelect());
foreach ($data as $currentTerm) {
$currentTerm['synonym_for'] = sprintf('%s, %s', $currentTerm['query_text'], $currentTerm['synonym_for']);
$result[] = sprintf("%s => %s", $currentTerm['query_text'], $currentTerm['synonym_for']);
$synonymFor = $this->escapeSynonym($currentTerm['synonym_for']);
$queryText = $this->escapeSynonym($currentTerm['query_text']);
$result[] = "{$queryText} => {$queryText}, {$synonymFor}";
}

return $result;
}

/**
* @param string $str
*
* @return string
*/
protected function escapeSynonym($str)
{
return strtr($str, $this->escapeMap);
}
}