WWSTCERT-9861 Add Zooz ZSE42 to zwave-sensor (for WWST Cert) #2683
Conversation
* Added sub_driver to handle populating firmewareUpdate.currentVersion * Added ability to set battery quantity and type in configurations
jtp10181
changed the title
greens
changed the title
it is needed for troubleshooting by Zooz support. The customer needs to be able to see the firmware version of the device. We will also be adding more sensors to this driver which need the same firmware version functionality, which is why I made it as a special sub driver just for the firmware version feature. |
|
Any other concerns or do I just have to wait for the approval now? |
| --Call main init function | ||
| driver.lifecycle_handlers.init(driver, device) | ||
| --Extras for this sub_driver | ||
| send_version_get(driver, device) |
There was a problem hiding this comment.
It often happens that, on hub restart, the init lifecycle event can be sent before the radio is fully initialized, resulting in radio send failures. Since you are only sending the get if the fw version is unpopulated, I would recommend moving this to the added handler.
There was a problem hiding this comment.
Or just leaving it exclusive to the wakeup handler. It may not get populated immediately, but will be eventually.
| local function wakeup_notification(driver, device, cmd) | ||
| send_version_get(driver, device) | ||
| --Call parent WakeUp functions | ||
| call_parent_handler(driver.zwave_handlers[cc.WAKE_UP][WakeUp.NOTIFICATION], driver, device, cmd) |
There was a problem hiding this comment.
I'd like to see a unit test to verify this works
2 participants
Type of Change
Checklist
Description of Change
Summary of Completed Tests