CHAD-17017: Add the ReadAttrbitue or refresh code for the initial state #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit 05cce9c. ♻️ This comment has been updated with latest results. |
|
zigbee-illuminance-sensor_coverage.xml
zigbee-switch_coverage.xml
zigbee-window-treatment_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 05cce9c |
greens
approved these changes
Dec 15, 2025
Contributor
|
@inasail looks like you have a test failing |
inasail
force-pushed
the
bugfix/CHAD-17017
branch
from
61ec8df to
e7ab0e6
Compare
Contributor
Author
|
@greens Thank you. I fixed it. Sorry for the mistake. |
Contributor
Author
|
@greens Please merge this PR. Thank you~ |
greens
reviewed
Jan 14, 2026
Comment on lines
83
to
84
| device:send(LockCluster.attributes.LockState:read(device)) | ||
| device:send(PowerConfiguration.attributes.BatteryPercentageRemaining:read(device)) |
Contributor
There was a problem hiding this comment.
These should already be read during the added lifecycle event, which calls refresh.
Contributor
Author
There was a problem hiding this comment.
Oh, you are right. I will remove those codes.
inasail
force-pushed
the
bugfix/CHAD-17017
branch
from
b001022 to
05cce9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartthings.atlassian.net/browse/CHAD-17017
Add refresh/readAttribute logic to retrieve the initial state fast.