fp2: During initialization, raise the init value instead of refresh #2269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
do_refresh
operates in two parts:state_update
(updates values via REST API)Currently, during initialization,
state_update()
is called redundantly:init
→update_connection
→create_sse
→ (SSE)on_create
→state_update
init
→do_refresh
→state_update
This duplication may cause conflicts. This can cause more issues, especially if the network conditions are poor.
To prevent this, instead of performing
do_refresh
at the end of init, I propose updating only impotant initialization values.Summary of Completed Tests
Verified operation with 3 FP2 devices connected at the same time to: