Wait for Max PIN length before generating credentials #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f317c94 |
This change fixes a bug where if the handler for `RequirePINforRemoteOperation` runs before the `maxCodeLength` attribute of the `lockCodes` capability is set, a default pin length of 4 would be used, which may be shorter than the minimum pin length of the device specified by the `MinPINCodeLength` attribute. Therefore, the read was removed from `init` and `added`, and was moved to the handler for `MaxPINCodeLength` to guarantee that the max pin length is known before attempting to generate the COTA credential.
nickolas-deboom
force-pushed
the
wait-for-max-pin-length-before-generating-cota-cred
branch
from
e68fcb3 to
f317c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
This change fixes a bug where if the handler for
RequirePINforRemoteOperationruns before themaxCodeLengthattribute of thelockCodescapability is set, a default pin length of 4 would be used, which may be shorter than the minimum pin length of the device specified by theMinPINCodeLengthattribute. Therefore, the read was removed frominitandadded, and was moved to the handler forMaxPINCodeLengthto guarantee that the max pin length is known before attempting to generate the COTA credential.Summary of Completed Tests
Updated UTs and tested on device.