Matter Thermostat: Improve test coverage and fix test cases for lower lua libs #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-deboom
changed the title
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 881effe |
Make tests backwards compatible down to lua libs api v10 and add test coverage for the following: * batteryLevel attribute handler * air purifier and air conditioner fan mode * water heater on lower lua libs versions * setpoint capabilities cached as Fahrenheit values
nickolas-deboom
force-pushed
the
matter-thermostat-fix-test-cases-for-lower-lua-libs
branch
from
26a0ba9 to
a7cf557
Compare
|
Invitation URL: |
FanModeSequence was not previously subscribed to for the room AC device type.
nickolas-deboom
force-pushed
the
matter-thermostat-fix-test-cases-for-lower-lua-libs
branch
from
a899f9d to
881effe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Add backwards compatibility for matter thermostat test cases down to lua libs version v10 and improve overall test coverage.
Note that to run these tests against lower versions, any capabilities that are not available in that version of the lua libs would need to be manually added to prevent test failures.
Summary of Completed Tests